Syntax Error

[346LSX]

 I am trying to set up a couple of scripts  Commanded Lambda and Lambda error,  my goal is to
plot Lambda Error vs MAF hz in a data map. GM.ENGINE.AFR is the only pid i have to use I tried to
create a script that takes this commanded AFR /14.68  I ended up with a error message:

SCRIPT.COMMANDED_LAMBDA:EXCEPTION 71:Syntax Error:missing)after formal parameters

Here is the script:

function GetRequiredPids(GM.ENGINE.AFR)
{
Obdii.AddRequiredPid(GM.ENGINE.AFR);
}   
var EngineRPM = Obdii.GetPidValueEnglish(GM.ENGINE.AFR);
var CalculatedValue;

if (GM.ENGINE.AFR== null)
{
   CalculatedValue = 0;
}
else
{
   CalculatedValue = GM.ENGINE.AFR / 14.68;
}

Obdii.PidValue.English = CalculatedValue; LAMBDA;


All this java script is new to me anyone know where I went wrong?

[Weston@PPE]

Your script should look more like this:

function GetRequiredPids()
{
    Obdii.AddRequiredPid("GM.ENGINE.AFR");
}   
var AirFuelRatio = Obdii.GetPidValueEnglish("GM.ENGINE.AFR");
var CalculatedValue;

if (AirFuelRatio == null)
{
   CalculatedValue = 0;
}
else
{
   CalculatedValue = AirFuelRatio / 14.68;
}

Obdii.PidValue.English = CalculatedValue;
Obdii.PidValue.Metric = CalculatedValue;

When you reference a PID, like with the GetPidValueEnglish function, it should have quotes around it because its a string. You also can't put just a PID name in and treat it like a variable (you did if(GM.ENGINE.AFR == null)), you need to use GetPidValueEnglish to save that value to a variable (which I named AirFuelRatio). It also looks like you were trying to set the units to LAMBDA, which should be done using the input boxes at the top of the script editing window. If you have any other trouble we're always here to help.

Keep trying though, and let us know how it all works out.

[346LSX]

  Thanks for the reply I have more to go on now.